-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(updater): Add Channel Support for Github with PreRelease #6505
feat(updater): Add Channel Support for Github with PreRelease #6505
Conversation
🦋 Changeset detectedLatest commit: be34e52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Deploy Preview for car-park-attendant-cleat-11576 ready! 🔨 Explore the source changes: be34e52 🔍 Inspect the deploy log: https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/61f2fee104fa520007454aa9 😎 Browse the preview: https://deploy-preview-6505--car-park-attendant-cleat-11576.netlify.app |
…g to be easier to use.
Whoops, seems there was an error in some code I suggested:
Since we don't care about number/null when comparing against alpha/beta, let's just wrap |
@mmaietta No problem, added that guard. |
Looks like eslint is throwing an error:
The rest of the warnings should be easily resolved through |
My bad I didn't realize I had prettier off on this project. |
Allows for apps to run updates using provided channel track.
This only works if
options.allowPreRelease
is true.If Channel is set in the updater, then latest will return the latest release that satisfies the logic in the builder docs
If Channel is NOT set but prerelease is set, then latest will return the latest release.
technically this also supports custom channels, but if you run one of those you will never be able to return to the Latest track.
I have marked this as a PR Draft as I would like to get discussion to make sure my logic is correct as well as this being my first contribution to this repo.
Tag:
#1722
#4988