Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: More small security fixes #6589

Merged

Conversation

devinbinnie
Copy link
Contributor

2 more small fixes:

  • Removed backtick escaping for Windows code signing as it is unnecessary for Powershell and can cause the script to attempt to access the wrong file
  • Updated the proxy filename to be more secure (512-bit string)

Let me know if I need to split these up or if I can leave it as one commit.

@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2022

🦋 Changeset detected

Latest commit: 198a695

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
electron-updater Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 28, 2022

✔️ Deploy Preview for car-park-attendant-cleat-11576 ready!

🔨 Explore the source changes: 198a695

🔍 Inspect the deploy log: https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/61f43afdbef3dd00074bb1fe

😎 Browse the preview: https://deploy-preview-6589--car-park-attendant-cleat-11576.netlify.app

@mmaietta
Copy link
Collaborator

mmaietta commented Jan 28, 2022

It's okay if it's within one PR. Please update the changeset file to be more specific though as that's what generates the changelogs. It can just be your ticket description

  • Removed backtick escaping for Windows code signing as it is unnecessary for Powershell and can cause the script to attempt to access the wrong file
  • Updated the proxy filename to be more secure (512-bit string)

@devinbinnie
Copy link
Contributor Author

Thanks @mmaietta. Should be good to merge now. 👍

@mmaietta mmaietta merged commit 633ee5d into electron-userland:master Jan 28, 2022
@github-actions github-actions bot mentioned this pull request Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants