Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(updater): Remove checks for app-update.yml when auto-updates are not supported #6616

Merged
merged 4 commits into from
Feb 6, 2022
Merged

fix(updater): Remove checks for app-update.yml when auto-updates are not supported #6616

merged 4 commits into from
Feb 6, 2022

Conversation

mmaietta
Copy link
Collaborator

@mmaietta mmaietta commented Feb 5, 2022

Moving isUpdaterActive check to checkForUpdates which is utilized by checkForUpdatesAndNotify. Fixes: #6322

@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 46782ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
electron-updater Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Feb 5, 2022 •
edited
Loading

✔️ Deploy Preview for car-park-attendant-cleat-11576 ready!

🔨 Explore the source changes: 46782ad

🔍 Inspect the deploy log: https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/61ff364ac1a42e0008881c3b

😎 Browse the preview: https://deploy-preview-6616--car-park-attendant-cleat-11576.netlify.app

@mmaietta mmaietta mentioned this pull request Feb 5, 2022
Closed
@mmaietta mmaietta merged commit 86e6d15 into master Feb 6, 2022
@mmaietta mmaietta deleted the fix/unnecessary-updater-checks branch February 6, 2022 16:20
@github-actions github-actions bot mentioned this pull request Feb 6, 2022
Merged
@mmaietta mmaietta mentioned this pull request Feb 9, 2022
Closed
@github-actions github-actions bot mentioned this pull request Feb 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
electron-updater mac
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

electron-builder not generating app-update.yml for Linux
1 participant
@mmaietta