Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove spctl check from Mac's notarization #7361

Merged
merged 2 commits into from
Jan 10, 2023
Merged

fix: Remove spctl check from Mac's notarization #7361

merged 2 commits into from
Jan 10, 2023

Conversation

filfreire
Copy link
Contributor

@filfreire filfreire commented Jan 10, 2023

Workaround fix for issue #7357

We found that the spctl check doesn't work well on Github Actions (and maybe other CI providers). This PR adds a workaround to skip that check when notarizing builds on Mac. (UPDATE) removes the spctl check after notarizing the Mac builds.

cc @mmaietta

@changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2023

🦋 Changeset detected

Latest commit: 227fcaa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Major
dmg-builder Major
electron-builder-squirrel-windows Major
electron-builder Major
electron-forge-maker-appimage Major
electron-forge-maker-nsis-web Major
electron-forge-maker-nsis Major
electron-forge-maker-snap Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 10, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 227fcaa
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/63bd97b017aff700089e28f5
😎 Deploy Preview https://deploy-preview-7361--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mmaietta
Copy link
Collaborator

I'm wondering if it'd be best to just remove that line of code entirely. What are your thoughts?

I used spctl locally and it's worked historically quite well, but it may be unnecessary since @electron/notarize seems to handle the verification as part of its Promise (and spitting out an error logs too).
https://github.com/electron/notarize/blob/cce06044e40049074f64ce0f58dd9e2be5406683/src/notarytool.ts#L80-L98

@filfreire
Copy link
Contributor Author

@mmaietta it was one of my temptations as well - remove it - because regularly - users who want to - do it themselves.

I'll change the PR to remove the step entirely.

@filfreire filfreire changed the title fix: add skipVerification workaround for MacOS notarize fix: Remove spctl check from Mac's notarization Jan 10, 2023
@filfreire
Copy link
Contributor Author

@mmaietta done - I removed the line entirely and updated the PR

@mmaietta mmaietta merged commit f9f23be into electron-userland:master Jan 10, 2023
@filfreire filfreire deleted the fix/workaround-issue-7357 branch January 16, 2023 17:16
@github-actions github-actions bot mentioned this pull request Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants