-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove spctl check from Mac's notarization #7361
fix: Remove spctl check from Mac's notarization #7361
Conversation
🦋 Changeset detectedLatest commit: 227fcaa The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I'm wondering if it'd be best to just remove that line of code entirely. What are your thoughts? I used |
@mmaietta it was one of my temptations as well - remove it - because regularly - users who want to - do it themselves. I'll change the PR to remove the step entirely. |
@mmaietta done - I removed the line entirely and updated the PR |
Workaround fix for issue #7357
We found that the
spctl
check doesn't work well on Github Actions (and maybe other CI providers). This PRadds a workaround to skip that check when notarizing builds on Mac.(UPDATE) removes thespctl
check after notarizing the Mac builds.cc @mmaietta