Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MAS builds should respect arch suffix per defaultArch config #7383

Merged
merged 2 commits into from
Jan 22, 2023

Conversation

radex
Copy link
Contributor

@radex radex commented Jan 18, 2023

It's possible to force electron-builder to explicitly name build archs by setting, for example defaultArch: ia32. In this case, you'll get builds like dist/mac-x64, dist/mac-arm64. However, MAS builds are not behaving consistently, as defaultArch was ignored.

@changeset-bot
Copy link

changeset-bot bot commented Jan 18, 2023

🦋 Changeset detected

Latest commit: a0e70d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 18, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit a0e70d4
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/63c82a49d0cdd10008e0f4c8
😎 Deploy Preview https://deploy-preview-7383--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mmaietta mmaietta changed the title MAS builds should respect arch suffix fix: MAS builds should respect arch suffix per defaultArch config Jan 18, 2023
@mmaietta mmaietta merged commit e5748b3 into electron-userland:master Jan 22, 2023
@github-actions github-actions bot mentioned this pull request Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants