Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Folder's named "constructor" not being included in asar #8286

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

beyondkmp
Copy link
Collaborator

@beyondkmp beyondkmp commented Jun 30, 2024

fix #8284

Refers to electron/asar#253

Copy link

changeset-bot bot commented Jun 30, 2024

🦋 Changeset detected

Latest commit: 1178ba0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jun 30, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 1178ba0
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/6680d689fd9f600008176311
😎 Deploy Preview https://deploy-preview-8286--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@beyondkmp
Copy link
Collaborator Author

I've verified it locally, and it's working fine.
image

@mmaietta mmaietta merged commit 4a4023c into electron-userland:master Jul 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Folder's named "constructor" not being included in asar
2 participants