Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete the symlink file when the target is empty #8371

Merged
merged 9 commits into from
Jul 24, 2024

Conversation

beyondkmp
Copy link
Collaborator

@beyondkmp beyondkmp commented Jul 23, 2024

Add the following filtering rule in the files section to exclude all files in the headers directory.

 "files": [
      "package.json",
      "!**/*.{h,cpp}"
    ]

image

This will result in an empty directory, which will not generate a corresponding empty directory in app.asar.unpack. However, the symbolic links for headers will still be present. This will cause an error during signing, stating that the corresponding files cannot be found.

Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 64bd061
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/66a07dc78df9ad00083b2a79
😎 Deploy Preview https://deploy-preview-8371--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

changeset-bot bot commented Jul 23, 2024

🦋 Changeset detected

Latest commit: 64bd061

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mmaietta mmaietta merged commit afd8132 into electron-userland:master Jul 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants