Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symlinked directories not included in asar #303

Closed
ttpssabc opened this issue Mar 4, 2024 · 1 comment · Fixed by #335
Closed

Symlinked directories not included in asar #303

ttpssabc opened this issue Mar 4, 2024 · 1 comment · Fixed by #335
Labels
bug released

Comments

@ttpssabc
Copy link

ttpssabc commented Mar 4, 2024

Hi!
If a directory is pointed to by a symbolic link whose name is the prefix of the directory, the directory won't be included in the asar.
For example, the directory aa won't be included.

├── a -> aa
└── aa

https://github.com/electron/asar/blob/main/lib/crawlfs.js#L30
@ttpssabc ttpssabc mentioned this issue Mar 4, 2024
Closed
@Akarinx Akarinx mentioned this issue Oct 23, 2024
Closed
mmaietta added a commit to mmaietta/asar that referenced this issue Oct 23, 2024
@mmaietta
fix: checking if symlink points outside the directory. (electron#303)
c8774f3
@mmaietta mmaietta mentioned this issue Oct 23, 2024
Merged
BlackHole1 pushed a commit that referenced this issue Nov 6, 2024
@mmaietta
fix: checking if symlink with same prefix points outside the directory (
9ec1830 
#335)

fix: checking if symlink points outside the directory. (#303)
@continuous-auth Continuous Auth
Copy link

🎉 This issue has been resolved in version 3.2.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: checking if symlink with same prefix points outside the directory mmaietta/asar
2 participants
@MarshallOfSound @ttpssabc