fix: remove unnecessary patch #20390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch which this pr removes adds new version of BrowserCompositorMac::GetCompositor. There is this function in BrowserCompositorMac with specifier const. Chromium's function returns parent's compositor if parent is set. Electron's version doesn't and - as a result - constrained dialogs won't be displayed correctly if they don't have its own compositor.
|
Patch which this pr removes was created by Cheng Zhao so he should know if removing it now is safe. |
brenca
approved these changes
Oct 2, 2019
|
Release Notes Persisted
|
|
@reviewers, please review release notes before merging a PR! Our checklist says:
The notes in this PR do not meet those criteria. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch which this pr removes adds new version of
BrowserCompositorMac::GetCompositor. There is this function in
BrowserCompositorMac with specifier const. Chromium's function
returns parent's compositor if parent is set. Electron's version
doesn't and - as a result - constrained dialogs won't be displayed
correctly if they don't have its own compositor.
Notes: removed unnecessary chromium patch for browser compositor on mac