Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated getTrafficLightPosition() / setTrafficLightPosition() #39479

Merged
merged 1 commit into from
Aug 21, 2023
Merged

chore: remove deprecated getTrafficLightPosition() / setTrafficLightPosition() #39479

merged 1 commit into from
Aug 21, 2023

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Aug 12, 2023 •
edited by ckerr
Loading

Description of Change

Follow-up to #37094

Checklist

Release Notes

Notes: Removed deprecated getTrafficLightPosition() and setTrafficLightPosition().

@miniak miniak requested a review from a team as a code owner August 12, 2023 09:08
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 12, 2023
@miniak miniak self-assigned this Aug 12, 2023
@miniak miniak requested a review from zcbenz August 12, 2023 09:09
@miniak miniak added semver/major incompatible API changes no-backport labels Aug 12, 2023
@miniak miniak force-pushed the miniak/traffic-light-position-cleanup branch 2 times, most recently from cafc518 to 2a4595c Compare August 14, 2023 09:37
ckerr
ckerr reviewed Aug 14, 2023
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

jkleinsc
jkleinsc reviewed Aug 14, 2023
View reviewed changes
Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

zcbenz
zcbenz approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@miniak miniak force-pushed the miniak/traffic-light-position-cleanup branch from 2a4595c to 711409f Compare August 19, 2023 12:12
@codebytere codebytere merged commit 90865fa into main Aug 21, 2023
@codebytere codebytere deleted the miniak/traffic-light-position-cleanup branch August 21, 2023 13:58
@release-clerk
Copy link

release-clerk bot commented Aug 21, 2023 •
edited by ckerr
Loading

Release Notes Persisted

Removed deprecated getTrafficLightPosition() and setTrafficLightPosition().

win32ss pushed a commit to win32ss/supermium-electron that referenced this pull request Sep 24, 2023
@miniak
chore: remove deprecated getTrafficLightPosition() / `setTrafficLig…
cdf874e 
…htPosition()` (electron#39479)

chore: remove deprecated getTrafficLightPosition() / setTrafficLightPosition()
@commit-lint commit-lint bot mentioned this pull request Nov 13, 2023
Open
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@miniak
chore: remove deprecated getTrafficLightPosition() / `setTrafficLig…
319f559 
…htPosition()` (electron#39479)

chore: remove deprecated getTrafficLightPosition() / setTrafficLightPosition()
@miniak miniak mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc left review comments

@ckerr ckerr ckerr left review comments

@deepak1556 deepak1556 deepak1556 approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees

@miniak miniak

Labels
api-review/approved ✅ no-backport semver/major incompatible API changes
Projects
Deprecation Board
Status: 🗑 Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@miniak @ckerr @jkleinsc @zcbenz @deepak1556 @codebytere