Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add error event for utility process (33-x-y) #43997

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

ckerr
Copy link
Member

@ckerr ckerr commented Sep 27, 2024

Manually backport #43774 to 33-x-y. See that PR for details.

Notes: Add error event in utility process to support diagnostic reports on V8 fatal errors

* feat: add error event for utility process

* chore: use public report api

* chore: fix lint

* doc: mark error event as experimental

---------

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@ckerr ckerr added backport This is a backport PR semver/minor backwards-compatible functionality target/32-x-y PR should also be added to the "32-x-y" branch. labels Sep 27, 2024
@trop trop bot mentioned this pull request Sep 27, 2024
5 tasks
@trop trop bot requested a review from a team September 27, 2024 14:30
@ckerr ckerr marked this pull request as draft September 27, 2024 18:50
remove #include "electron/mas.h"

this header did not exist before c1c8fbf
@ckerr ckerr marked this pull request as ready for review September 27, 2024 19:14
@ckerr ckerr merged commit 5836ea1 into 33-x-y Sep 29, 2024
50 checks passed
Copy link

release-clerk bot commented Sep 29, 2024

Release Notes Persisted

Add error event in utility process to support diagnostic reports on V8 fatal errors

@ckerr ckerr deleted the robo/expose_sandbox_error--33-x-y branch September 29, 2024 22:12
@trop
Copy link
Contributor

trop bot commented Sep 29, 2024

I was unable to backport this PR to "32-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/32-x-y PR should also be added to the "32-x-y" branch. label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
33-x-y backport/requested 🗳 backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants