-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The installed version of @vercel/webpack-asset-relocator-loader does not appear to be compatible with Forge
on new patch version of dev dependency @vercel/webpack-asset-relocator-loader
#3600
Comments
Four days ago (as of May 20, 2024), version 1.7.4 of the @vercel/webpack-asset-relocator-loader package was released At the moment it is not compatible, so if you get this error, go to the package.json, and in the dependencies look for this:
And remove node_modules folder and reinstall with npm install / yarn or similar. All the best! |
Hey @eXhumer and @robertomsen, thanks for the reports here! This is definitely related to a PR landing upstream in the |
Did |
changing ^1.7.3 to 1.7.3 in package.json for "@vercel/webpack-asset-relocator-loader" dependency fixed the issue for me |
@uncaught Forge currently currently relies on a specific version of that package being installed. Here's the explanation from the docs:
|
* Remove minor TS warnings * Temporarily remove eslint from dependencies It has some sort of node requirement which prevents upgrading anything else. * Upgrade all packages to latest * Update date-fns calls to new version * Remove asset loading in main process WebPack config The main process should have no assets. * Downgrade webpack-asset-relocator-loader to 1.7.3 See electron/forge#3600 * Fix calls to formatDistanceToNow by fixing definitions of timestamps updatedAt and gitnewsSeenAt are quite different and their types were wrong. * Install octokit * Update tests to remove chai and sinon * Remove chai and sinon * Set node version in GH actions * Fix TS errors in middleware * Remove octokit * Add semver types * Downgrade electron-store to 8.2 This prevents the issue described here: sindresorhus/electron-store#276 The recommended solution that issue is to convert the entire project to ESM, which I've attempted in #183, but it doesn't seem to work because of incompatibilities between Webpack and Electron Forge that I haven't been able to resolve. So for now I'm just going to downgrade. (The app works fine with or without the errors.) * Ignore extras directory
Pre-flight checklist
Electron Forge version
7.4.0
Electron version
30.0.6
Operating system
macOS 14.4.1 (arm64)
Last known working Electron Forge version
No response
Expected behavior
Able to upgrade outdated dependency for a package without breaking development build.
Actual behavior
Upon running
npm upgrade
on package, I can no longer start the development build withstart
script as it fails with the following error.Console output with errors
Steps to reproduce
Additional information
@vercel/webpack-asset-relocator-loader
recently released a version 1.7.4. The package is added to a clean build of electron-forge with@vercel/webpack-asset-relocator-loader@^1.7.3
. Runningnpm upgrade
will cause this issue to appear. I modified bypackage.json
to modify the the dependency to remove^
and rerunningnpm upgrade
, locking it to 1.7.3, which seems to fix the issue for now.The text was updated successfully, but these errors were encountered: