Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add --inspect-brk-electron option #1328

Merged
merged 3 commits into from
Feb 24, 2022

Conversation

MOZGIII
Copy link
Contributor

@MOZGIII MOZGIII commented Dec 8, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

A simple change to support passing --inspect-brk option to electron.

Closes #2342

@MOZGIII MOZGIII changed the title Add --inspect-brk support cli: --inspect-brk support Dec 8, 2019
@MOZGIII MOZGIII changed the title cli: --inspect-brk support feat(cli): --inspect-brk support Dec 8, 2019
@MOZGIII MOZGIII force-pushed the inspect-brk-support branch from 7a943ce to b7dd71c Compare December 8, 2019 17:28
@MOZGIII
Copy link
Contributor Author

MOZGIII commented Dec 8, 2019

@malept and @MarshallOfSound, could you take a look at this PR and provide your feedback, please?
This is a blocker for me.

@MOZGIII
Copy link
Contributor Author

MOZGIII commented Mar 7, 2020

Any progress on this?

@MOZGIII MOZGIII force-pushed the inspect-brk-support branch from 55c4424 to d84bcd9 Compare March 7, 2020 04:41
@MOZGIII MOZGIII changed the title feat(cli): --inspect-brk support feat(cli): add --inspect-brk-electron option Mar 7, 2020
@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #1328 (5fda58f) into master (8d4e903) will decrease coverage by 0.14%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1328      +/-   ##
==========================================
- Coverage   64.12%   63.97%   -0.15%     
==========================================
  Files          77       77              
  Lines        2606     2751     +145     
  Branches      583      684     +101     
==========================================
+ Hits         1671     1760      +89     
- Misses        752      808      +56     
  Partials      183      183              
Impacted Files Coverage Δ
packages/api/core/src/util/upgrade-forge-config.ts 70.51% <0.00%> (-4.85%) ⬇️
...lisher/electron-release-server/src/PublisherERS.ts 27.27% <0.00%> (-0.42%) ⬇️
packages/api/core/src/api/start.ts 55.67% <50.00%> (+6.78%) ⬆️
packages/plugin/webpack/src/WebpackConfig.ts 98.73% <100.00%> (ø)
packages/api/core/src/api/init-scripts/init-git.ts 70.58% <0.00%> (-15.13%) ⬇️
packages/maker/base/src/Maker.ts 56.14% <0.00%> (-7.13%) ⬇️
packages/utils/async-ora/src/ora.ts 54.05% <0.00%> (-6.56%) ⬇️
packages/api/core/src/api/make.ts 58.82% <0.00%> (-5.94%) ⬇️
...ges/api/core/src/api/init-scripts/find-template.ts 74.07% <0.00%> (-5.93%) ⬇️
packages/utils/async-ora/src/ora-handler.ts 71.11% <0.00%> (-5.82%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9abc581...5fda58f. Read the comment docs.

@VerteDinde VerteDinde merged commit c5a6ea1 into electron:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --inspect-brk-electron
3 participants