Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template): remove TS warning while scaffolding TS templates #1664

Merged
merged 2 commits into from
Aug 11, 2020

Conversation

deadcoder0904
Copy link
Contributor

@deadcoder0904 deadcoder0904 commented May 4, 2020

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

By default, TS gives a warning,

Missing return type on function.eslint@typescript-eslint/explicit-function-return-type

So I removed the warning by adding a return type void :)

@malept malept changed the title fix: remove TS warning while scaffolding TS templates fix(template): remove TS warning while scaffolding TS templates Aug 11, 2020
@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #1664 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1664      +/-   ##
==========================================
- Coverage   72.71%   72.62%   -0.10%     
==========================================
  Files          74       74              
  Lines        2210     2210              
  Branches      416      416              
==========================================
- Hits         1607     1605       -2     
- Misses        443      445       +2     
  Partials      160      160              
Impacted Files Coverage Δ
packages/maker/flatpak/src/MakerFlatpak.ts 78.26% <0.00%> (-8.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6a65ca...c35e7ec. Read the comment docs.

@malept malept merged commit e447adc into electron:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants