Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add params to the postPackage hook #1896

Merged
merged 2 commits into from
Aug 11, 2020

Conversation

malept
Copy link
Member

@malept malept commented Aug 11, 2020

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Adds the following parameters to postPackage:

  • platform
  • arch
  • outputPaths (the result of await packager(...))
  • spinner (the ora spinner, if defined)

Docs are at electron-forge/electron-forge-docs#12

Also, DRYs up the "update package.json" code.

Fixes #1630.

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #1896 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1896   +/-   ##
=======================================
  Coverage   72.71%   72.71%           
=======================================
  Files          74       74           
  Lines        2210     2210           
  Branches      416      416           
=======================================
  Hits         1607     1607           
  Misses        443      443           
  Partials      160      160           
Impacted Files Coverage Δ
packages/api/core/src/api/package.ts 74.73% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a311e32...83dcef4. Read the comment docs.

@malept malept merged commit e9a2ba0 into master Aug 11, 2020
@malept malept deleted the malept/feat/postpackage-hook-args branch August 11, 2020 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

postPackage hook should inject arch, platform, target
1 participant