Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add electronegativity plugin #1900

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

malept
Copy link
Member

@malept malept commented Aug 11, 2020

Summarize your changes:

Adds a first-party plugin for Electronegativity, which runs after packaging is done.

There is an associated PR for the electronforge.io docs.

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #1900 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1900   +/-   ##
=======================================
  Coverage   72.71%   72.71%           
=======================================
  Files          74       74           
  Lines        2210     2210           
  Branches      416      416           
=======================================
  Hits         1607     1607           
  Misses        443      443           
  Partials      160      160           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5602da6...acd10c8. Read the comment docs.

@malept
Copy link
Member Author

malept commented Aug 11, 2020

It might be interesting at some point to parse the output of the Electronegativity API call and throw an error if, for example, there are high severity items found. But this is a good first pass.

@malept malept merged commit a6a65ca into master Aug 11, 2020
@malept malept deleted the malept/feat/plugin-electronegativity branch August 11, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant