Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): don't hardcode the minimum required Node version #2003

Merged
merged 3 commits into from
Oct 21, 2020

Conversation

malept
Copy link
Member

@malept malept commented Oct 21, 2020

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Also has a little refactor and adds a warning message.

@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #2003 into master will decrease coverage by 0.04%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2003      +/-   ##
==========================================
- Coverage   72.69%   72.65%   -0.05%     
==========================================
  Files          74       74              
  Lines        2216     2220       +4     
  Branches      419      420       +1     
==========================================
+ Hits         1611     1613       +2     
- Misses        443      444       +1     
- Partials      162      163       +1     
Impacted Files Coverage Δ
packages/api/cli/src/util/check-system.ts 71.42% <63.63%> (-2.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ee708...0f0ab66. Read the comment docs.

@malept malept merged commit 704db4b into master Oct 21, 2020
@malept malept deleted the malept/fix/non-hardcoded-check-node-version branch October 21, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant