chore(maker-rpm): map arm64 -> aarch64 #3137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
The canonical name used by the
rpm
package is aarch64. The current behavior of leaving the name arm64 unmapped can lead to subtle behavior differences, since during the RPM building process, the platform name is used for matching against macros under/usr/lib/rpm/platform/<platform>/macros
, and the platform name there isaarch64-linux
. Mapping to aarch64 also ensures that the behavior of--arch=arm64
is the same as running on a Linux Arm64 machine, whereuname
will be returning aarch64, not arm64.Note that this does change the extension of the final RPM to
*.aarch64.rpm
instead of*.arm64.rpm
.