Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-fuses): use target platform in the executable path #3376

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

erikian
Copy link
Member

@erikian erikian commented Oct 8, 2023

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
We're using the host platform instead of the target platform to get the binary path, which results in an incorrect path when making for a different platform (like /path/to/electron.exe instead of /path/to/electron when making for Linux on Windows).

@erikian erikian requested a review from a team as a code owner October 8, 2023 19:16
Copy link
Member

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! If you could also optimize the code, it would be even better.

@erickzhao erickzhao merged commit 6762429 into main Oct 20, 2023
3 checks passed
@erickzhao erickzhao deleted the fix/fuses-executable-path branch October 20, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants