Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove electron-prebuilt-compile support #3396

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

erickzhao
Copy link
Member

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

BREAKING CHANGE: plugin-compile has been discontinued and Forge no longer supports electron-prebuilt or electron-prebuilt-compile.

Did a search and removed all instances of plugin-compile and electron-prebuilt from the codebase.

BREAKING CHANGE: plugin-compile has been discontinued and Forge
no longer supports `electron-prebuilt` or `electron-prebuilt-compile`.
@erickzhao erickzhao requested a review from a team as a code owner November 1, 2023 21:49
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works well!

@erickzhao erickzhao merged commit 126867d into main Nov 2, 2023
8 checks passed
@erickzhao erickzhao deleted the delete-plugin-compile branch November 2, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants