refactor: dedupe key resolver for static publishers #3421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixrieseberg
approved these changes
Nov 20, 2023
Brooooooklyn
referenced
this pull request
in toeverything/AFFiNE
Dec 11, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@electron-forge/maker-base](https://github.com/electron/forge) | [`7.1.0` -> `7.2.0`](https://renovatebot.com/diffs/npm/@electron-forge%2fmaker-base/7.1.0/7.2.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>electron/forge (@​electron-forge/maker-base)</summary> ### [`v7.2.0`](https://github.com/electron/forge/releases/tag/v7.2.0) [Compare Source](https://github.com/electron/forge/compare/v7.1.0...v7.2.0) #### What's Changed ##### Features - feat: add support for sequential groups of webpack builds by [@​MarshallOfSound](https://github.com/MarshallOfSound) in [https://github.com/electron/forge/pull/3435](https://github.com/electron/forge/pull/3435) ##### Fixes - fix: handle webpack configs exported as default by [@​MarshallOfSound](https://github.com/MarshallOfSound) in [https://github.com/electron/forge/pull/3427](https://github.com/electron/forge/pull/3427) - fix: set empty publicPath for preload scripts by [@​MarshallOfSound](https://github.com/MarshallOfSound) in [https://github.com/electron/forge/pull/3428](https://github.com/electron/forge/pull/3428) - fix: ensure that webpack is run once per arch for universal builds by [@​MarshallOfSound](https://github.com/MarshallOfSound) in [https://github.com/electron/forge/pull/3433](https://github.com/electron/forge/pull/3433) ##### Documentation - docs: remove mention of v5 -> v6 migration by [@​erickzhao](https://github.com/erickzhao) in [https://github.com/electron/forge/pull/3412](https://github.com/electron/forge/pull/3412) - docs: add notes on publishing a new monorepo package by [@​erickzhao](https://github.com/erickzhao) in [https://github.com/electron/forge/pull/3415](https://github.com/electron/forge/pull/3415) ##### Other Changes - build(docs): enable API documentation builds for Forge v7 by [@​erickzhao](https://github.com/erickzhao) in [https://github.com/electron/forge/pull/3413](https://github.com/electron/forge/pull/3413) - ci: allow manual API documentation publish by [@​dsanders11](https://github.com/dsanders11) in [https://github.com/electron/forge/pull/3414](https://github.com/electron/forge/pull/3414) - refactor: dedupe key resolver for static publishers by [@​MarshallOfSound](https://github.com/MarshallOfSound) in [https://github.com/electron/forge/pull/3421](https://github.com/electron/forge/pull/3421) - chore: bump electronjs/node to 2.1.0 (main) by [@​electron-roller](https://github.com/electron-roller) in [https://github.com/electron/forge/pull/3422](https://github.com/electron/forge/pull/3422) - chore: update deps to clear some audit warnings by [@​dsanders11](https://github.com/dsanders11) in [https://github.com/electron/forge/pull/3429](https://github.com/electron/forge/pull/3429) **Full Changelog**: electron/forge@v7.1.0...v7.2.0  </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/toeverything/AFFiNE). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6ImNhbmFyeSJ9-->
](https://renovatebot.com){kind=link}
Brooooooklyn
referenced
this pull request
in toeverything/AFFiNE
Dec 11, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@electron-forge/maker-base](https://github.com/electron/forge) | [`7.1.0` -> `7.2.0`](https://renovatebot.com/diffs/npm/@electron-forge%2fmaker-base/7.1.0/7.2.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>electron/forge (@​electron-forge/maker-base)</summary> ### [`v7.2.0`](https://github.com/electron/forge/releases/tag/v7.2.0) [Compare Source](https://github.com/electron/forge/compare/v7.1.0...v7.2.0) #### What's Changed ##### Features - feat: add support for sequential groups of webpack builds by [@​MarshallOfSound](https://github.com/MarshallOfSound) in [https://github.com/electron/forge/pull/3435](https://github.com/electron/forge/pull/3435) ##### Fixes - fix: handle webpack configs exported as default by [@​MarshallOfSound](https://github.com/MarshallOfSound) in [https://github.com/electron/forge/pull/3427](https://github.com/electron/forge/pull/3427) - fix: set empty publicPath for preload scripts by [@​MarshallOfSound](https://github.com/MarshallOfSound) in [https://github.com/electron/forge/pull/3428](https://github.com/electron/forge/pull/3428) - fix: ensure that webpack is run once per arch for universal builds by [@​MarshallOfSound](https://github.com/MarshallOfSound) in [https://github.com/electron/forge/pull/3433](https://github.com/electron/forge/pull/3433) ##### Documentation - docs: remove mention of v5 -> v6 migration by [@​erickzhao](https://github.com/erickzhao) in [https://github.com/electron/forge/pull/3412](https://github.com/electron/forge/pull/3412) - docs: add notes on publishing a new monorepo package by [@​erickzhao](https://github.com/erickzhao) in [https://github.com/electron/forge/pull/3415](https://github.com/electron/forge/pull/3415) ##### Other Changes - build(docs): enable API documentation builds for Forge v7 by [@​erickzhao](https://github.com/erickzhao) in [https://github.com/electron/forge/pull/3413](https://github.com/electron/forge/pull/3413) - ci: allow manual API documentation publish by [@​dsanders11](https://github.com/dsanders11) in [https://github.com/electron/forge/pull/3414](https://github.com/electron/forge/pull/3414) - refactor: dedupe key resolver for static publishers by [@​MarshallOfSound](https://github.com/MarshallOfSound) in [https://github.com/electron/forge/pull/3421](https://github.com/electron/forge/pull/3421) - chore: bump electronjs/node to 2.1.0 (main) by [@​electron-roller](https://github.com/electron-roller) in [https://github.com/electron/forge/pull/3422](https://github.com/electron/forge/pull/3422) - chore: update deps to clear some audit warnings by [@​dsanders11](https://github.com/dsanders11) in [https://github.com/electron/forge/pull/3429](https://github.com/electron/forge/pull/3429) **Full Changelog**: electron/forge@v7.1.0...v7.2.0  </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/toeverything/AFFiNE). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6ImNhbmFyeSJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit of some fancy class inheritance stuff going on here 😆 But basically all to dedupe the key resolver logic for the two static publishers we have and I guess all future ones we add / others want to make