Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

Commit

Permalink
chore: remove unused private RuntimeAgent member env
Browse files Browse the repository at this point in the history
Removed in nodejs/node#28036; this patch can
be removed when we update to v12.5.0
  • Loading branch information
codebytere committed Jul 3, 2019
1 parent 79187b3 commit 9a0a953
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 5 deletions.
1 change: 1 addition & 0 deletions filenames.json
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,7 @@
"src/node_env_var.cc",
"src/node_errors.cc",
"src/node_file.cc",
"src/node_snapshot_stub.cc",
"src/node_http_parser_llhttp.cc",
"src/node_http_parser_traditional.cc",
"src/node_http2.cc",
Expand Down
4 changes: 4 additions & 0 deletions src/inspector/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ _protocol_generated = [
"protocol/NodeWorker.h",
"protocol/NodeTracing.cpp",
"protocol/NodeTracing.h",
"protocol/NodeRuntime.cpp",
"protocol/NodeRuntime.h"
]

# These are from node_protocol_config.json
Expand Down Expand Up @@ -41,6 +43,8 @@ source_set("inspector") {
"worker_agent.h",
"worker_inspector.cc",
"worker_inspector.h",
"runtime_agent.cc",
"runtime_agent.h",
]
sources += rebase_path(_protocol_generated,
".",
Expand Down
4 changes: 2 additions & 2 deletions src/inspector/runtime_agent.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ namespace node {
namespace inspector {
namespace protocol {

RuntimeAgent::RuntimeAgent(Environment* env)
: notify_when_waiting_for_disconnect_(false), env_(env) {}
RuntimeAgent::RuntimeAgent()
: notify_when_waiting_for_disconnect_(false) {}

void RuntimeAgent::Wire(UberDispatcher* dispatcher) {
frontend_ = std::make_unique<NodeRuntime::Frontend>(dispatcher->channel());
Expand Down
3 changes: 1 addition & 2 deletions src/inspector/runtime_agent.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ namespace protocol {

class RuntimeAgent : public NodeRuntime::Backend {
public:
explicit RuntimeAgent(Environment* env);
explicit RuntimeAgent();

void Wire(UberDispatcher* dispatcher);

Expand All @@ -23,7 +23,6 @@ class RuntimeAgent : public NodeRuntime::Backend {
private:
std::shared_ptr<NodeRuntime::Frontend> frontend_;
bool notify_when_waiting_for_disconnect_;
Environment* env_;
};
} // namespace protocol
} // namespace inspector
Expand Down
2 changes: 1 addition & 1 deletion src/inspector_agent.cc
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ class ChannelImpl final : public v8_inspector::V8Inspector::Channel,
tracing_agent_->Wire(node_dispatcher_.get());
worker_agent_ = std::make_unique<protocol::WorkerAgent>(worker_manager);
worker_agent_->Wire(node_dispatcher_.get());
runtime_agent_ = std::make_unique<protocol::RuntimeAgent>(env);
runtime_agent_ = std::make_unique<protocol::RuntimeAgent>();
runtime_agent_->Wire(node_dispatcher_.get());
}

Expand Down

0 comments on commit 9a0a953

Please sign in to comment.