Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

Commit

Permalink
fix: don't create console window when creating process
Browse files Browse the repository at this point in the history
This commit prevents console windows from being spawned when creating processes to better align with what Windows users expect and should be removed when upgrading to a version that includes nodejs/node#21316
  • Loading branch information
codebytere committed Jun 20, 2019
1 parent 6aee817 commit f5ae970
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions deps/uv/src/win/process.c
Original file line number Diff line number Diff line change
Expand Up @@ -1099,6 +1099,9 @@ int uv_spawn(uv_loop_t* loop,
process_flags |= DETACHED_PROCESS | CREATE_NEW_PROCESS_GROUP;
}

/* Don't create console window. */
process_flags |= CREATE_NO_WINDOW;

if (!CreateProcessW(application_path,
arguments,
NULL,
Expand Down

0 comments on commit f5ae970

Please sign in to comment.