MSVC warning fixes #545
Open
MSVC warning fixes #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… compiler setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My dependent project uses
set( CMAKE_CXX_STANDARD 20 )and has/W0set for libraries. This causes warnings to be generated from the EASTL sources as a result of the settings being injected byCommonCppFlags.cmake.This pull request still keeps W4 for EASTL, but falls back to replacing rather than appending to prevent duplicating the /W# argument. It also unsets CMAKE_CXX_STANDARD to prevent cmake from generating a duplicate language specification.