Adds support to choose between JLINK and BMP as programmers #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The targets of flash, flash_softdevice and erase work based on what the variable DEBUGGER is set as: JLINK or BMP.
|
You seem to have hardcoded the USB port:
That will not work on Windows and Linux. Instead, it should be a Eg.:
Also I think we need a check on DEBUGGER - if it's already from cmd line, it should take precedence. eg.:
|
|
What is this 'Windows' that you speak of? :P OK, I'll see what I can do for making it compatible with both the OS. Also there is an issue with the path of nrfjprog. I'll fix that too. |
|
|
This commit removes the hardcoding of the BMP port to /dev/ttyBmpGdb so that people using other OS apart from Linux can set it appropriately.
|
Ok, I've made the changes. Untested in Windows and Mac though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The targets of flash, flash_softdevice and erase work based
on what the variable DEBUGGER is set as: JLINK or BMP.
Needs
arm-none-eabi-gdbin the path for BMP to work.