Don't clear 'remotes' field from 'info' command during updating slot map #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevino
reviewed
Feb 23, 2017
src/slot.c
Outdated
| @@ -47,13 +47,19 @@ static inline void node_list_init() | |||
| conf_node_dec_ref(node); | |||
| } | |||
|
|
|||
| static inline void node_list_add(struct node_info *node) | |||
| static inline void node_list_add(struct address *dst, size_t *len, struct node_info *node) | |||
There was a problem hiding this comment.
node_list_* are targeted at the global node_list, I guess we should keep the consistency somehow.
There was a problem hiding this comment.
OK, I will change its name.
doyoubi
force-pushed
the
feature/AmendRemotes
branch
from
6164134 to
36b5302
Compare
doyoubi
force-pushed
the
feature/AmendRemotes
branch
from
36b5302 to
79fa2ce
Compare
doyoubi
changed the title
tevino
reviewed
Feb 27, 2017
| if (num > 0) { | ||
| memcpy(tmp_nodes + tmp_nodes_len, n->nodes, num * sizeof(struct address)); | ||
| tmp_nodes_len += num; | ||
| } |
There was a problem hiding this comment.
It would be great to wrap these into a function, it's an append operation after all.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the node list of corvus config file is wrong, once rebooted corvus can't retrieve the node list anymore. We need to find out this kind of corvus by checking whether the
remotesfield frominfocommand is empty.However, when corvus try updating its slot map, it will clear the its inner node list first, which will also result in empty
remotesfield before successfully retrieving the node list. So we can not tell whether there's something wrong with the node list of corvus even though there's emptyremotes.This PR changed this behavior. Now we only clear the node list after fail to update slot.