Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse port until the end or to an @ symbol #124

Merged
merged 3 commits into from
Aug 7, 2017

Conversation

badboy
Copy link
Contributor

@badboy badboy commented Apr 7, 2017

Newer Redis Cluster includes the bus port in the output of CLUSTER NODES,
appened to the default ip:port tuple after an @ symbol.

Reference: redis/redis@b841f3ad1

Newer Redis Cluster includes the bus port in the output of `CLUSTER NODES`,
appened to the default ip:port tuple after an @ symbol.

Reference: redis/redis@b841f3ad1
@doyoubi
Copy link
Contributor

doyoubi commented Apr 9, 2017

Thanks for helping us with the compability problem.
We are testing the current version of corvus in one of our IDC and going to release 0.2.6 after we are done. Sorry to say that for stability considerations this modification may not be merged into 0.2.6 but next version.
We will test this PR this week.

@badboy
Copy link
Contributor Author

badboy commented Apr 9, 2017

Fully understand not merging in a bug fix release that doesn't officially support Redis >3 anyway. Happy to help out for future compatibility

@doyoubi
Copy link
Contributor

doyoubi commented Apr 12, 2017

We will finally merge this when the modification of CLUSTER NODES in redis is merged into redis 3.2.

@doyoubi doyoubi mentioned this pull request Aug 5, 2017
@doyoubi
Copy link
Contributor

doyoubi commented Aug 7, 2017

Now the redis 4 has been released with the new format of CLUSTER NODES. I'm going to merge this to keep compatible with the new redis version.

@doyoubi doyoubi merged commit 71db51c into eleme:master Aug 7, 2017
@doyoubi doyoubi mentioned this pull request Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants