Fixes for EditInPlace control #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which wasn't quite tall enough to stop the component gaining height when adding a caption
and fix arg type
Deploying compound-web with
|
| Latest commit: |
bdea683
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b1a5796f.compound-web.pages.dev |
| Branch Preview URL: | https://dbkr-editinplace-fixes.compound-web.pages.dev |
t3chguy
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little pick-n-mix of small changes to the EditInPlace component. May be easier to review commit-by-commit (each commit explains what it does individually).
There will be a separate PR for the in-progress spinner as it involves adding the spinner component.