Bring back the tooltip warm-up period #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robintown
requested review from
dbkr and
t3chguy
and removed request for
a team
To make it easier to browse through tooltips on neighboring elements, a common UX optimization is to allow the hover delay to be "warmed up", so that it goes to zero after the first hover. We used to have this before the tooltip component was rewritten. This is a breaking change because consumers are now required to wrap their application in a <TooltipProvider> component once again.
robintown
force-pushed
the
warmup-period
branch
from
fc3b61c
to
f550d26
Compare
Deploying compound-web with
|
| Latest commit: |
f550d26
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1c38d084.compound-web.pages.dev |
| Branch Preview URL: | https://warmup-period.compound-web.pages.dev |
robintown
changed the title
dbkr
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it easier to browse through tooltips on neighboring elements, a common UX optimization is to allow the hover delay to be "warmed up", so that it goes to zero after the first hover. We used to have this before the tooltip component was rewritten.
Screencast.from.2024-08-02.12-41-01.webm
This is a breaking change because consumers are now required to wrap their application in a <TooltipProvider> component once again. I thought it'd be nice to do this before the next release because #229 and #211 are already breaking.