Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interoperability for graphemer import #58

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

germain-gg
Copy link
Contributor

To work around flmnt/graphemer#11

This will fix the failing jest tests in matrix-org/matrix-react-sdk#11393
Runtime works because it is using the ESM module.

Thank you @sandhose for the pointer 🙇

@germain-gg germain-gg requested a review from sandhose August 10, 2023 15:19
@germain-gg germain-gg requested a review from a team as a code owner August 10, 2023 15:19
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 81b206e
Status: ✅  Deploy successful!
Preview URL: https://53e8345f.compound-web.pages.dev
Branch Preview URL: https://germain-gg-graphemer-fix.compound-web.pages.dev

View logs

Copy link
Member

@sandhose sandhose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

js packaging is fun

@germain-gg germain-gg merged commit f6bd7b7 into main Aug 10, 2023
@germain-gg germain-gg deleted the germain-gg/graphemer-fix branch August 10, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants