Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning to private space creation flow #3490

Merged
merged 2 commits into from
Jun 16, 2021
Merged

Add warning to private space creation flow #3490

merged 2 commits into from
Jun 16, 2021

Conversation

BillCarsonFr
Copy link
Member

Fixes #3485
image

@BillCarsonFr BillCarsonFr requested review from bmarty and ganfra June 11, 2021 07:24
@BillCarsonFr BillCarsonFr added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Jun 11, 2021
bmarty
bmarty approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small remark, else LGTM

vector/src/main/java/im/vector/app/features/spaces/SpaceCreationActivity.kt Outdated
}
super.onFragmentDetached(fm, f)
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should find a way to improve this code, or at least do not duplicate it everywhere...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to use only inter-fragment communication without going through the hosting activity.
Looks cleaner as only the two communicating fragments are modified
It's using #setFragmentResultListener and #setFragmentResult

vector/src/main/java/im/vector/app/features/spaces/create/BetaWarningBottomSheet.kt Outdated
override val showExpanded = true

override fun onDetach() {
interactionListener = null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setting to null is done several times then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's defensive coding, but can remove

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see previous reply

@BillCarsonFr BillCarsonFr force-pushed the feature/bca/fix_3485 branch from 87106db to bc120da Compare June 15, 2021 12:01
bmarty
bmarty approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. I will update the TextView style after the merge

@bmarty bmarty merged commit b5cc023 into develop Jun 16, 2021
@bmarty bmarty deleted the feature/bca/fix_3485 branch June 16, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

@ganfra ganfra Awaiting requested review from ganfra

Assignees
No one assigned
Labels
Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add warning to private space creation flow
2 participants
@BillCarsonFr @bmarty