Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump compile and target SDK to 34 #8860

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Bump compile and target SDK to 34 #8860

merged 6 commits into from
Jul 17, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jul 5, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Bump compile and target SDK to 34 to be able to publish on the PlayStore after August 31th.

Also take the opportunity to upgrade many libraries.

Need to perform Realm migration. Upgrade from the version in the develop branch tested OK with a connected account.

Motivation and context

Closes #8863

Screenshots / GIFs

Tests

  • Smoke test

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty force-pushed the feature/bma/sdk34 branch 3 times, most recently from e4de9bf to 064839b Compare July 15, 2024 12:47
Use fully qualified R classes
Fix or ignore deprecation
Update github actions and ensure JDK 17 is used
Add group for paparazzi
Fixes Lint issues
Fix Jacoco configuration
Copy link

sonarcloud bot commented Jul 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.8% Coverage on New Code (required ≥ 80%)
3.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@bmarty
Copy link
Member Author

bmarty commented Jul 17, 2024

Let's merge this big one so that it will be in the next nightly.

@bmarty bmarty merged commit 96e05ba into develop Jul 17, 2024
12 of 13 checks passed
@bmarty bmarty deleted the feature/bma/sdk34 branch July 17, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set targetSdk to 34
1 participant