Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screen sharing got stuck with stream on still frame #742

Closed
dbkr opened this issue Nov 9, 2022 · 1 comment · Fixed by matrix-org/matrix-js-sdk#2992
Closed

Screen sharing got stuck with stream on still frame #742

dbkr opened this issue Nov 9, 2022 · 1 comment · Fixed by matrix-org/matrix-js-sdk#2992
Labels
A-Screenshare O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems

Comments

@dbkr
Copy link
Member

dbkr commented Nov 9, 2022

Steps to reproduce

Florian started screen sharing but then wanted to share a different screen. He stopped, but then on clicking the screenshare button again, it didn't prompt for which window and instead resumed the screen share with a static frame.

Outcome

What did you expect?

What happened instead?

Operating system

No response

Browser information

Firefox

URL for webapp

No response

Will you send logs?

Yes
@dbkr dbkr added the T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems label Nov 9, 2022
@RiotRobot RiotRobot moved this to Incoming in Element Call issue triage Nov 9, 2022
@robintown robintown added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Screenshare labels Nov 9, 2022
@robintown robintown moved this from Incoming to Triaged in Element Call issue triage Nov 9, 2022
@dbkr
Copy link
Member Author

dbkr commented Dec 16, 2022

Just ran into this while fixing a different bug - turns out the cause is that we don't terminate screenshare feeds for individual calls when a member leaves.

Repro steps:

  1. Join group call with at least 3 participants
  2. Start screenshare from one
  3. One of the other participants leaves
  4. Stop screensharing
  5. Press screenshare button again

Same screenshare feed appears rather than it re-prompting you for what you want to share (for me it was still a live view of that window rather than a still frame).

dbkr added a commit to matrix-org/matrix-js-sdk that referenced this issue Dec 16, 2022
@dbkr
Close all streams when a call ends
96ee5b1 
We didn't close streams in group calls (presumably from back when
we used the same stream for all calls rather than cloning?) but this
left stray screenshare streams in the mediahandler when a participant
left whilst we were screensharing.

Fixes element-hq/element-call#742
@dbkr dbkr mentioned this issue Dec 16, 2022
Merged
3 tasks
Repository owner moved this from Triaged to Closed in Element Call issue triage Dec 19, 2022
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Jan 19, 2023
@su-ex
Merge tag 'v23.1.0' into sc
e6c127a 
* Remove extensible events v1 field population on legacy events ([\matrix-org#3040](matrix-org#3040)).
* Improve hasUserReadEvent and getUserReadUpTo realibility with threads ([\matrix-org#3031](matrix-org#3031)). Fixes element-hq/element-web#24164.
* Remove video track when muting video ([\matrix-org#3028](matrix-org#3028)). Fixes element-hq/element-call#209.
* Make poll start event type available (PSG-962) ([\matrix-org#3034](matrix-org#3034)).
* Add alt event type matching in Relations model ([\matrix-org#3018](matrix-org#3018)).
* Remove usage of v1 Identity Server API ([\matrix-org#3003](matrix-org#3003)).
* Add `device_id` to `/account/whoami` types ([\matrix-org#3005](matrix-org#3005)).
* Implement MSC3912: Relation-based redactions ([\matrix-org#2954](matrix-org#2954)).
* Introduce a mechanism for using the rust-crypto-sdk ([\matrix-org#2969](matrix-org#2969)).
* Support MSC3391: Account data deletion ([\matrix-org#2967](matrix-org#2967)).
* Fix threaded cache receipt when event holds multiple receipts ([\matrix-org#3026](matrix-org#3026)).
* Fix false key requests after verifying new device ([\matrix-org#3029](matrix-org#3029)). Fixes element-hq/element-web#24167 and element-hq/element-web#23333.
* Avoid triggering decryption errors when decrypting redacted events ([\matrix-org#3004](matrix-org#3004)). Fixes element-hq/element-web#24084.
* bugfix: upload OTKs in sliding sync mode ([\matrix-org#3008](matrix-org#3008)).
* Apply edits discovered from sync after thread is initialised ([\matrix-org#3002](matrix-org#3002)). Fixes element-hq/element-web#23921.
* Sliding sync: Fix issue where no unsubs are sent when switching rooms ([\matrix-org#2991](matrix-org#2991)).
* Threads are missing from the timeline ([\matrix-org#2996](matrix-org#2996)). Fixes element-hq/element-web#24036.
* Close all streams when a call ends ([\matrix-org#2992](matrix-org#2992)). Fixes element-hq/element-call#742.
* Resume to-device message queue after resumed sync ([\matrix-org#2920](matrix-org#2920)). Fixes matrix-org/element-web-rageshakes#17170.
* Fix browser entrypoint ([\matrix-org#3051](matrix-org#3051)). Fixes matrix-org#3013.
* Fix failure to start in firefox private browser ([\matrix-org#3058](matrix-org#3058)). Fixes element-hq/element-web#24216.
* Correctly handle limited sync responses by resetting the thread timeline ([\matrix-org#3056](matrix-org#3056)). Fixes element-hq/element-web#23952.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Screenshare O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
No open projects
Element Call issue triage
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close all streams when a call ends matrix-org/matrix-js-sdk
2 participants
@dbkr @robintown