-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build the deb into a repo #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm
scripts/mkrepo.sh
Outdated
set -x | ||
set -e | ||
|
||
ver=`node -e "require('fs'); console.log(JSON.parse(fs.readFileSync('package.json')).version)"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤢🤮
NodeJS is great, but ohgod. Can we use something like jq
instead? Stack Overflow says it is possible: https://stackoverflow.com/questions/53967693/how-to-run-jq-from-gitbash-in-windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe, but it's another thing everyone has to install, and we know we have node... (This is building the deb repo so this one we don't need to work in windows).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't sound too painful to require another dependency (it's the same apt-get?)
and also remove env.sh which didn;t want to be here
With distributions configured by the config dir because that determines the signing key
Fixes element-hq/element-web#11649
Based on #17