Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #19218 Find the i18n files with underscore #338

Closed
wants to merge 2 commits into from
Closed

Issue #19218 Find the i18n files with underscore #338

wants to merge 2 commits into from

Conversation

TPiUnikie
Copy link
Contributor

@TPiUnikie TPiUnikie commented Apr 13, 2022

Find the i18n files from asar package with underscore on filename.
#871


This PR currently has no changelog labels, so will not be included in changelogs.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

@TPiUnikie TPiUnikie requested a review from a team as a code owner April 13, 2022 14:04
@t3chguy
Copy link
Member

t3chguy commented Apr 13, 2022

@TPiUnikie TPiUnikie closed this Apr 13, 2022
@TPiUnikie TPiUnikie reopened this Apr 19, 2022
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! As per t3chguy's comment, this needs signoff before we can realistically consider it.

@dbkr
Copy link
Member

dbkr commented Apr 25, 2022

This seems to be the same as #339 ? Closing since the other one is merged.

@dbkr dbkr closed this Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants