Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build, Sign & Notarise macOS builds #486

Merged
merged 37 commits into from
Jan 31, 2023
Merged

Build, Sign & Notarise macOS builds #486

merged 37 commits into from
Jan 31, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Dec 13, 2022 •
edited by github-actions bot
Loading

https://til.simonwillison.net/electron/sign-notarize-electron-macos has been an invaluable resource here

Unfortunately notarisation in GHA seems almighty slow.

image

On the dedicated mac mini the whole build takes ~10 mins, about 3.5x faster and that is without the hak caching we do here.

This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Tasks for the team like planning label Dec 13, 2022
@t3chguy t3chguy temporarily deployed to develop December 13, 2022 12:45 — with GitHub Actions Inactive
@t3chguy t3chguy temporarily deployed to develop December 13, 2022 13:15 — with GitHub Actions Inactive
@t3chguy t3chguy temporarily deployed to develop December 13, 2022 14:24 — with GitHub Actions Inactive
@t3chguy t3chguy temporarily deployed to develop December 14, 2022 10:53 — with GitHub Actions Inactive
@t3chguy t3chguy temporarily deployed to develop December 14, 2022 11:21 — with GitHub Actions Inactive
@t3chguy t3chguy temporarily deployed to develop December 14, 2022 11:28 — with GitHub Actions Inactive
@t3chguy t3chguy temporarily deployed to develop December 14, 2022 11:57 — with GitHub Actions Inactive
@t3chguy t3chguy temporarily deployed to develop December 14, 2022 12:17 — with GitHub Actions Inactive
@t3chguy t3chguy had a problem deploying to packages.element.io December 14, 2022 12:58 — with GitHub Actions Failure
@t3chguy t3chguy temporarily deployed to develop December 14, 2022 13:14 — with GitHub Actions Inactive
@t3chguy t3chguy marked this pull request as ready for review January 16, 2023 12:11
@t3chguy t3chguy requested review from a team as code owners January 16, 2023 12:11
@t3chguy t3chguy requested review from andybalaam and dbkr January 16, 2023 12:11
andybalaam
andybalaam approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as far as I understand it. Some optional comments and questions.

Thank you for your work on this!

.github/workflows/build_and_deploy.yaml Show resolved Hide resolved
.github/workflows/build_and_deploy.yaml Show resolved Hide resolved
.github/workflows/build_and_deploy.yaml Show resolved Hide resolved
.github/workflows/build_macos.yaml Outdated Show resolved Hide resolved
.github/workflows/build_macos.yaml Outdated Show resolved Hide resolved
.github/workflows/build_macos.yaml Outdated Show resolved Hide resolved
scripts/generate-builder-config.ts Show resolved Hide resolved
scripts/generate-builder-config.ts Show resolved Hide resolved
@t3chguy t3chguy mentioned this pull request Jan 19, 2023
Closed
40 tasks
@t3chguy t3chguy temporarily deployed to packages.element.io January 30, 2023 17:15 — with GitHub Actions Inactive
@t3chguy t3chguy had a problem deploying to packages.element.io January 30, 2023 17:17 — with GitHub Actions Failure
@t3chguy t3chguy temporarily deployed to packages.element.io January 30, 2023 17:17 — with GitHub Actions Inactive
@t3chguy t3chguy had a problem deploying to packages.element.io January 30, 2023 17:18 — with GitHub Actions Failure
@t3chguy t3chguy temporarily deployed to packages.element.io January 30, 2023 17:20 — with GitHub Actions Inactive
@t3chguy t3chguy temporarily deployed to packages.element.io January 30, 2023 17:21 — with GitHub Actions Inactive
@t3chguy t3chguy temporarily deployed to packages.element.io January 30, 2023 18:05 — with GitHub Actions Inactive
@t3chguy t3chguy requested a review from andybalaam January 31, 2023 10:45
andybalaam
andybalaam approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look reasonable.

@t3chguy t3chguy merged commit e5117f9 into develop Jan 31, 2023
@t3chguy t3chguy deleted the t3chguy/notarize1 branch January 31, 2023 13:22
@t3chguy t3chguy mentioned this pull request Mar 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybalaam andybalaam andybalaam approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @andybalaam