Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unpadded base64 for secrets data stored in SSSS #3669

Closed
manuroe opened this issue Sep 18, 2020 · 1 comment · Fixed by matrix-org/matrix-ios-sdk#916
Closed

Use unpadded base64 for secrets data stored in SSSS #3669

manuroe opened this issue Sep 18, 2020 · 1 comment · Fixed by matrix-org/matrix-ios-sdk#916
Assignees
@manuroe
Milestone
Sprint 31

Comments

@manuroe
Copy link
Member

manuroe commented Sep 18, 2020

@uhoreg advises that all platform should do like the android-sdk, ie:

 EncryptedSecretContent(
                ciphertext = cipherBytes.toBase64NoPadding(),
                initializationVector = iv.toBase64NoPadding(),
                mac = digest.toBase64NoPadding()
        )
@manuroe manuroe added this to the Sprint 31 milestone Sep 18, 2020
@manuroe manuroe mentioned this issue Sep 18, 2020
Open
@manuroe
Copy link
Member Author

manuroe commented Sep 18, 2020

Kamino cloned this issue to vector-im/element-web

@manuroe manuroe self-assigned this Sep 18, 2020
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue Sep 18, 2020
@manuroe
SSSS: Use unpadded base64 for secrets data
be7be36 
element-hq/element-ios/issues/3669

This changes will not affect other clients (web, android) or existing data. It is only driven by consistency across platforms.
@manuroe manuroe mentioned this issue Sep 18, 2020
Merged
@manuroe manuroe mentioned this issue Sep 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuroe manuroe

Labels
None yet
Projects
None yet
Milestone
Sprint 31
Development

Successfully merging a pull request may close this issue.

SSSS: Use unpadded base64 for secrets data matrix-org/matrix-ios-sdk
1 participant
@manuroe