E2E: SAS Verification #2372
Merged
E2E: SAS Verification #2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e verification flow when the user taps on "Verify"
…automatically cancelled
Riot/AppDelegate.m
Outdated
| deviceVerificationCoordinatorBridgePresenter = nil; | ||
|
|
||
| // TODO: Why? | ||
| dispatch_after(dispatch_time(DISPATCH_TIME_NOW, 1 * NSEC_PER_SEC), dispatch_get_main_queue(), ^{ |
There was a problem hiding this comment.
You could add a completion on dismiss like dismissAnimated:completion: on DeviceVerificationCoordinatorBridgePresenter
|
|
||
| // MARK: Public | ||
|
|
||
| var userId: String |
There was a problem hiding this comment.
All properties below from userId to mediaManager should use let instead of var
| NotificationCenter.default.addObserver(self, selector: #selector(themeDidChange), name: .themeServiceDidChangeTheme, object: nil) | ||
| } | ||
|
|
||
| private func loadData() { |
There was a problem hiding this comment.
Using MVVM-C pattern, code in this method should be moved in a view model.
| // MARK: - DeviceVerificationStartViewModelCoordinatorDelegate | ||
| extension DeviceVerificationStartCoordinator: DeviceVerificationStartViewModelCoordinatorDelegate { | ||
| func deviceVerificationStartViewModelUseLegacyVerification(_ viewModel: DeviceVerificationStartViewModelType) { | ||
| // TODO |
|
|
||
| @IBOutlet private weak var titleLabel: UILabel! | ||
| @IBOutlet private weak var informationLabel: UILabel! | ||
| @IBOutlet weak var waitingPartnerLabel: UILabel! |
There was a problem hiding this comment.
Missing some private on outlets
|
|
||
| @IBOutlet private weak var titleLabel: UILabel! | ||
| @IBOutlet private weak var informationLabel: UILabel! | ||
| @IBOutlet weak var decimalLabel: UILabel! |
There was a problem hiding this comment.
Missing some private on outlets
…ithout a random sleep
SBiOSoftWhare
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-ios-sdk#652.
Closes #2323