Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle session states better #5503

Merged
merged 5 commits into from
Feb 8, 2022
Merged

Handle session states better #5503

merged 5 commits into from
Feb 8, 2022

Conversation

ismailgulek
Copy link
Contributor

@ismailgulek ismailgulek commented Feb 4, 2022

  • Uses readable session states when logging for missed places.
  • Adds some error logs around event/(null) requests.
  • Updates in MXKAccount to gracefully pause the session on certain states.

Fixes #5426 and requires matrix-org/matrix-ios-sdk#1359

@github-actions
Copy link

github-actions bot commented Feb 4, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/FE543i

Copy link
Member

@manuroe manuroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ismailgulek ismailgulek merged commit dfc916d into develop Feb 8, 2022
@ismailgulek ismailgulek deleted the ismail/5426_uisis branch February 8, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NSE failed to persist megolm sessions, causing an explosion of UISIs
2 participants