Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix settings screens items alignment #6311

Merged
merged 2 commits into from
Jun 17, 2022

Conversation

aringenbach
Copy link
Contributor

@aringenbach aringenbach commented Jun 17, 2022

Fixes alignment issues inside all settings screen.

iOS has some inconsistencies on what is returned by separatorInset property of a cell. This uses the tableView separatorInset instead, to make sure that everything is always perfectly aligned.

Also it sets MXKTableViewCellWithLabelAndTextField's label to be left aligned instead of center since it could break alignment in some cases.

Before After
image image

@sonarcloud
Copy link

sonarcloud bot commented Jun 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aringenbach aringenbach requested review from a team, SBiOSoftWhare, phloux and MaximeEvrard42 and removed request for a team and SBiOSoftWhare June 17, 2022 13:21
Copy link
Contributor

@MaximeEvrard42 MaximeEvrard42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link
Contributor

@phloux phloux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@codecov-commenter
Copy link

Codecov Report

Merging #6311 (1203d94) into develop (5aba712) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #6311      +/-   ##
===========================================
- Coverage     6.23%    6.23%   -0.01%     
===========================================
  Files         1440     1440              
  Lines       155383   155385       +2     
  Branches     62528    62528              
===========================================
- Hits          9684     9681       -3     
- Misses      145296   145301       +5     
  Partials       403      403              
Impacted Files Coverage Δ
...oomDetails/EnterNewRoomDetailsViewController.swift 0.00% <0.00%> (ø)
...Modules/Room/Settings/RoomSettingsViewController.m 0.00% <0.00%> (ø)
...curity/ManageSession/ManageSessionViewController.m 0.00% <0.00%> (ø)
...Modules/Settings/Security/SecurityViewController.m 0.00% <0.00%> (ø)
Riot/Modules/Settings/SettingsViewController.m 0.00% <0.00%> (ø)
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.34% <0.00%> (-0.31%) ⬇️
...ules/MatrixKit/Models/Room/MXKRoomBubbleCellData.m 16.75% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aba712...1203d94. Read the comment docs.

@aringenbach aringenbach merged commit a8e7bf9 into develop Jun 17, 2022
@aringenbach aringenbach deleted the aringenbach/fix_settings_leading_alignment branch June 17, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants