Show Matrix RTC calls as unsupported. #7862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
force-pushed
the
doug/matrix-rtc
branch
from
a77ff88
to
43b1a35
Compare
|
bmarty
reviewed
Nov 12, 2024
| @@ -200,4 +200,4 @@ SPEC CHECKSUMS: | |||
|
|
|||
| PODFILE CHECKSUM: 484a1cdf04951cc82156f29de196efd76d3ad893 | |||
|
|
|||
| COCOAPODS: 1.15.2 | |||
| COCOAPODS: 1.14.3 | |||
There was a problem hiding this comment.
Not a specialist but strange to see a downgrade here. Is it a mistake?
There was a problem hiding this comment.
Nah, it was just out of sync with the Gemfile. That happens when someone runs pod install instead of bundle exec pod install. Thanks for double-checking though 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
m.call.notifyevents in the NSE (only whenm.mentionsincludes you) showing an unsupported call notification.m.call.notifyevents in the timeline as unsupported calls.Part of #7861
EX on the left | EI on the right
Screen.Recording.2024-11-08.at.5.25.00.pm.mov