-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prompt to accept integration manager polices on use #10088
Comments
This will require a change to scalar (to expose a policy document) - will this also require a spec change? |
see #10087 (comment) |
We considered whether it would be possible for Scalar to handle this "internally" (i.e. scalar presents HTML that gets rendered in iframes in Riot, so why not just let it do this same trick to handle t's and c's acceptance) - however, by the time it rendered such an acceptance UX you would already have shared the mxid with the integration manager via OpenID, so this is not feasible. |
After validating today, latest comps are in Zeplin: https://zpl.io/brMdWo3 |
This defers the work to request the IM token when displaying a widget until after we know that widget will actually be shown and the user has granted permission for this widget to be displayed. This is useful in general to avoid making unnecessary token checks, but it's particularly helpful with the new Terms API, so that we only show the Terms flow when widget are actually being used (as opposed to entering the room where widgets exist, but haven't been shown / permitted). Part of element-hq/element-web#10088
One portion fixed by matrix-org/matrix-react-sdk#3240 |
The rest of this issue will be fixed by matrix-org/matrix-react-sdk#3199 |
For historical tracking, I did not notice the in-context agreement tooltips from the Zeplin designs while working on this, so this only makes the general terms modal appear at the right moments. |
(If we still want the in-context agreement tooltips from the design, we should file a new issue to track that.) |
Kamino cloned this issue to vector-im/riot-ios |
Filed #10422 for the more contextual version intended by the designs. |
Before you:
You must read and agree to the policy documents provided by the integration manager
The text was updated successfully, but these errors were encountered: