Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag rageshakes via React soft crash / error boundary to indicate the app was broken #11072

Closed
jryans opened this issue Oct 7, 2019 · 2 comments · Fixed by matrix-org/matrix-react-sdk#3535
Closed

Tag rageshakes via React soft crash / error boundary to indicate the app was broken #11072

jryans opened this issue Oct 7, 2019 · 2 comments · Fixed by matrix-org/matrix-react-sdk#3535
Assignees
@jryans
Labels
A-Feedback-Reporting Reporting process for bugs, debug logs (rageshakes), suggestions P1 T-Enhancement

Comments

@jryans
Copy link
Collaborator

jryans commented Oct 7, 2019

For rageshakes submitted via the React error boundary, we should tag these somehow in rageshake metadata to indicate the priority.
@jryans jryans added feature P1 A-Feedback-Reporting Reporting process for bugs, debug logs (rageshakes), suggestions labels Oct 7, 2019
@turt2live
Copy link
Member

ftr, the rageshake server does support labels (the mobile apps use this). We could also go with old school prefixes on the message: [WSOD] User message here

@jryans
Copy link
Collaborator Author

jryans commented Oct 7, 2019

I guess WSOD is a bad name, since the colour depends on theme... Will use "soft crash" term as with #11045.

@jryans jryans changed the title Tag rageshakes via React WSOD to indicate the app was broken Tag rageshakes via React soft crash / error boundary to indicate the app was broken Oct 7, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Oct 9, 2019
@jryans
Add label to rageshakes for React soft crashes
e905abe 
This adds a label all rageshakes submitted via the React error boundary marking
them as soft crashes for triage.

Fixes element-hq/element-web#11072
@jryans jryans mentioned this issue Oct 9, 2019
Merged
@jryans jryans self-assigned this Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Feedback-Reporting Reporting process for bugs, debug logs (rageshakes), suggestions P1 T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add label to rageshakes for React soft crashes matrix-org/matrix-react-sdk
2 participants
@jryans @turt2live