Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcuts: Cmd/Ctrl-. to toggle the right panel #12248

Closed
jryans opened this issue Feb 5, 2020 · 4 comments · Fixed by matrix-org/matrix-react-sdk#4244
Closed

Shortcuts: Cmd/Ctrl-. to toggle the right panel #12248

jryans opened this issue Feb 5, 2020 · 4 comments · Fixed by matrix-org/matrix-react-sdk#4244
Assignees

Comments

@jryans
Copy link
Collaborator

jryans commented Feb 5, 2020

We should consider adding Cmd/Ctrl-. as a shortcut to toggle the right panel, matching popular apps like Slack.

@madduck
Copy link

madduck commented Feb 5, 2020

Please make it configurable.

@nadonomy
Copy link
Contributor

We should consider adding Cmd/Ctrl-. as a shortcut to toggle the right panel, matching popular apps like Slack.

SGTM! In the long term, I think there's some things to untangle re whether this shortcut should also collapse the left panel, but I'd advocate for us to defer that until later.

@t3chguy
Copy link
Member

t3chguy commented Feb 10, 2020

How does one toggle the right panel, closing it is obvious but then should we re-open whatever state was last open? What if that state was mid-way through verification which has since timed out and whatnot? Should it just be the latest of the 3 top-level options (member list, file list, notif list)

@jryans
Copy link
Collaborator Author

jryans commented Feb 10, 2020

Should it just be the latest of the 3 top-level options (member list, file list, notif list)

Hmm, yes, I suspect this would be the natural approach to start with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants