Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for theming and templating. #12314

Closed
jsonjuri opened this issue Feb 11, 2020 · 1 comment
Closed

Improvements for theming and templating. #12314

jsonjuri opened this issue Feb 11, 2020 · 1 comment

Comments

@jsonjuri
Copy link

jsonjuri commented Feb 11, 2020

Riot IM is a great piece of work but still way too static for customization.

Here are some suggestions for improvement:

Themes:
Currently, themes are more like color schemes. For example, we want to have different images, sounds, icons, and fonts in our themes. That is not possible because most of the images/icons are hardcoded to its path like: require("../../../../res/img/icon_person.svg").

A more logic setup of the res folder would be like:

  • res
    • css (core css) some core css what shouldn't be able to change.
    • img (core images) like logo, flags, emoji
    • fonts (core fonts) emoji fonts
    • themes
      • the_matrix (example)
        • img (theme images)
        • css (theme css)
          • components
            • a folder with overrides for all components css.
          • light.css
          • dark.css
        • fonts (main font used for theme) In this case Nunito
        • media (different sounds for themes would be nice, for example "The Matrix" theme with some matrix sounds :)
      • default (default theme)
        ...

Images

  • There are many PNG images inside the /img folder which I cannot find any relationship inside the project code. I think this folder can get a cleanup? :)

  • There are many duplicates of icons in many sizes and colors. I think they could be scaled and colored using CSS instead.

Uploads
There is a great upload tool named Uppy where users can select their files directly from social media or cloud services. The implementation of Uppy would be a huge improvement to its current upload tool.

@t3chguy
Copy link
Member

t3chguy commented May 23, 2022

Themes

Closing in favour of issues like #5844 + #18741 + #13223

There are many PNG images inside the /img folder which I cannot find any relationship inside the project code. I think this folder can get a cleanup? :)

If you have specific examples do point them out, many clean ups have happened, keep in mind the project is multi-layered.

There are many duplicates of icons in many sizes and colors. I think they could be scaled and colored using CSS instead.

This is done intentionally, the SVGs are often authored with some of the small details missing on the smaller variants as they are simply not clear at that size. The icons are authored for specific render resolutions.

There is a great upload tool named Uppy where users can select their files directly from social media or cloud services. The implementation of Uppy would be a huge improvement to its current upload tool.

It is not possible for us to use something like Uppy due to it requiring a server-to-server "companion" - https://uppy.io/docs/companion/ - Element runs entirely in your browser, connecting only to services which speak Matrix

@t3chguy t3chguy closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2022
t3chguy pushed a commit that referenced this issue Oct 17, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants