Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Rejoindre" ("Join" in french) button in explore room modal doesn't fit #15347

Closed
henricazottes opened this issue Oct 1, 2020 · 2 comments · Fixed by matrix-org/matrix-react-sdk#5551
Closed

"Rejoindre" ("Join" in french) button in explore room modal doesn't fit #15347

henricazottes opened this issue Oct 1, 2020 · 2 comments · Fixed by matrix-org/matrix-react-sdk#5551
Labels
A-Room-Directory P2 S-Tolerable Low/no impact on users T-Defect

Comments

@henricazottes
Copy link

henricazottes commented Oct 1, 2020 •
edited
Loading

style_bug_element

Description

This image is speaking for itself, the join button doesn't fit in the modal for french language.

Steps to reproduce

  • set language to French
  • click on explore rooms

Version information

  • Platform: web in-browser

For the web app:
@henricazottes henricazottes changed the title Join button in explore room modal doesn't fit "Rejoindre" ("Join" in french) button in explore room modal doesn't fit Oct 1, 2020
@dbkr dbkr added P2 S-Tolerable Low/no impact on users A-Room-Directory labels Oct 1, 2020
@weeman1337 weeman1337 mentioned this issue Jan 17, 2021
Merged
@t3chguy t3chguy mentioned this issue Jan 22, 2021
Closed
@slsimic
Copy link
Contributor

slsimic commented Jan 23, 2021

Does this fix consider space for the Preview translated string also?
See #16244 for the screenshot

@jryans
Copy link
Collaborator

jryans commented Jan 25, 2021

Does this fix consider space for the Preview translated string also?

Yes, it adapts for both.

@jryans jryans removed the Z-UI/UX label Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Room-Directory P2 S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch room explorer list to CSS grid weeman1337/matrix-react-sdk
4 participants
@jryans @dbkr @henricazottes @slsimic