This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Switch room explorer list to CSS grid #5551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weeman1337
force-pushed
the
fix-15347-explore-rooms-spacing
branch
from
3e7b296 to
73c3a5e
Compare
jryans
suggested changes
Jan 21, 2021
weeman1337
force-pushed
the
fix-15347-explore-rooms-spacing
branch
2 times, most recently
from
586e1e6 to
2f3570c
Compare
jryans
approved these changes
Jan 27, 2021
|
Ah curious, the end to end tests failed... I have retried them, let's see what happens. |
|
@jryans is there anything I can do? Looks like some timeouts are happening. |
|
Try pulling in latest develop e.g |
|
@weeman1337 Yes, looks like the tests should pass once you merge in latest changes from develop. |
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
weeman1337
force-pushed
the
fix-15347-explore-rooms-spacing
branch
from
2f3570c to
f0f6e46
Compare
|
@jryans done. Today I regret to not having finished this before the fosdem. The room list - urgh |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the issue that languages require different spacing for the buttons.
Keyboard navigation works like before.
before
after
English
Français
Closes element-hq/element-web#15347