-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention State Indicator Design Reworking #1841
Comments
The other ambiguities we need to pin down are:
If you can discuss the options for the above with trevor and propose a solution such that we can sign-off on it would be much appreciated. |
I'll draw all this up, but, suggested solution:
|
this sounds good to me. Only concerns are:
@wmwragg: looks like to avoid further confusion we should put this on hold until trevor has drawn it up so we can be 100% sure we're all on the same page and avoid further iteration. Sorry again for the dead ends on this, and thanks for your patience. |
Right you are, I'll let Trevor lead on this for now then |
One final implicit expectation that I should make explicit (as per chat a few mins ago) is that i'd expect selecting a room just to add the highlight - not to otherwise change the physical layout. This is the behaviour on the current master branch (i.e. /beta). On /develop, the layout now pops for a given RoomTile when it's selected. |
Anything else?
The text was updated successfully, but these errors were encountered: