Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LHS Implementation feedback #1922

Closed
wmwragg opened this issue Aug 3, 2016 · 4 comments
Closed

LHS Implementation feedback #1922

wmwragg opened this issue Aug 3, 2016 · 4 comments
Assignees
Labels

Comments

@wmwragg
Copy link
Contributor

wmwragg commented Aug 3, 2016

This collects the feedback on the LHS changes made for tickets #1746 and #1841

@wmwragg
Copy link
Contributor Author

wmwragg commented Aug 3, 2016

  • The weight of rooms with unread messages is too hard to distinguish from unread (other than perhaps on retina displays), especially on muted rooms. Can we consider revising the design to increase the weight of the label text? This has only come up after having used it in practice.
  • It's common for people to mute lots of rooms to hide notifs, whilst still actively participating in them. Therefore muted rooms being entirely greyed out is quite disconcerting. Perhaps we keep the text ungreyed for muted rooms, but leave the greyed mute icon as it is. This has only come up after having used it in practice - fixed in Wmwragg/mute mention state fix #1926 and Wmwragg/mute mention state fix matrix-org/matrix-react-sdk#390
  • Hitmask on the selectors of the dropdown mentions menu should include the bullets - fixed in Wmwragg/mute mention state fix #1926 and Wmwragg/mute mention state fix matrix-org/matrix-react-sdk#390
  • Hitmask for switching room should be larger - fixed on the matrix-react-sdk:wmwragg/mention-state-menu branch

@ara4n
Copy link
Member

ara4n commented Aug 3, 2016

  • Bolded long truncated can collide with the badge and look ugly (this on Chrome 52 on Linux):

screenshot from 2016-08-03 17 3a39 3a00

fixed in #1926 and matrix-org/matrix-react-sdk#390

@ara4n
Copy link
Member

ara4n commented Aug 6, 2016

The only remaining item here is on the weighting question for @antikewl

@ara4n
Copy link
Member

ara4n commented Sep 8, 2016

this wave of feedback all got gathered and sorted.

@ara4n ara4n closed this as completed Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants