Implement Knocking on Element Web

[jakewb-b]

Links

• PRD (internal): https://docs.google.com/document/d/15ornTrYI5UYVkvlHcD89IIhYIKvdfZcPn6V-KVnMmx8/edit
• Spec: https://spec.matrix.org/v1.2/client-server-api/#knocking-on-rooms
• Figma designs: https://www.figma.com/file/7TqjqdMBaPpm3IavKsMYu6/%5BBWI%5D-Knocking?type=design&node-id=367-50166&mode=design&t=6Bjqu0KINaAjkbV0-0
• Screenshots of proposed design: Implement Knocking on Element Web #18655 (comment) (superceded by Figma??)
• Already implemented by Synapse, just need UI

Mobile (out of scope for this issue): See element-hq/element-android#3875 and element-hq/element-ios#4731

Tasks

Preview Give feedback

1. Cannot request to join a room for more than one room vector-im/element-web#26043
   A-Knocking O-Uncommon S-Major T-Defect Z-Labs +5
2. Room join request not remembered vector-im/element-web#26044
   A-Knocking O-Uncommon S-Minor T-Defect Z-Labs +5
3. Avatars are cut off in knocking people section vector-im/element-web#26083
   A-Knocking T-Defect Z-Labs +3
4. Stuck if knock is rejected vector-im/element-web#26084
   A-Knocking O-Uncommon S-Major T-Defect Z-Labs +5
5. Auto-join rooms when knock accepted matrix-org/synapse#16307
   A-Join A-User-Experience O-Occasional S-Minor T-Defect +5
6. Room knocking via spaces doesn't work #27025
   A-Knocking A-Spaces O-Uncommon S-Major T-Defect Z-Labs +6
   

[Mikaela]

I am unable to open either of the links from the original submission and am wondering whether it's noted that this is part of Matrix protocol specification version 1.1?

• https://spec.matrix.org/latest/client-server-api/#knocking-on-rooms

[turt2live]

Screenshots of the designs for inspiration (in no particular order):

[noantiq]

I was wondering, why would you move the "People" tab to settings instead of leaving it in the side panel and adding a new category for Access Requests in the same way as there is a category for invited people already?

[t3chguy]

I was wondering, why would you move the "People" tab to settings instead of leaving it in the side panel and adding a new category for Access Requests in the same way as there is a category for invited people already?

Its not moved, the People right panel card remains, just won't show knocks to prevent noise/spam.

Settings already has a people section (people with non-default power levels) - this just extends that list.

[turt2live]

it would actually be its own tab - the existing roles & permissions tab gets split in two for clarity. The member list on the right side of the room remains unchanged in any case, however.

[enekonieto]

Would it be interesting if members with enough privileges see the knock in the timeline?

[Mikaela]

If I understand correctly, everyone in the room will see the knocking as it's a membership event, unless Element Web especially hides that (which I imagine would then be visible through /devtools or another client). To answer the knock necessary PL is the one to invite or kick (or ban)

[enekonieto]

I think the event in the timeline should have the Accept/Reject buttons for users with enough PL. I comment this because I don't see the timeline in the prototype sent by @turt2live.

The settings screen being the only way to accept knocks seems not very comfortable to me (I don't know if that's the idea).

[Mikaela]

Does this issue include that when join rule is set to knock or knock_restricted, Element Web settings "who can join this room" has radio button menu with nothing checked? Or does knock_restricted need a new issue?

My room versions are 9 and 10.

[turt2live]

It would be a later stage of development

[Mikaela]

The previous time I used knocking was yesterday when we bridged an ICT team from Telegram to Matrix. We couldn't use restricted as that would have required us to already have a room with everyone and due to the room's nature we couldn't make it fully public.

I am also utilising knock_restricted in my personal rooms a lot.

Thus I would like to ask if there has been any progress with supporting knocking in Elements as it's a feature of Matrix Spec 1.1 with Matrix Spec 1.5 being around the coner? matrix-org/matrix-spec#1337

[turt2live]

Knocking is still low on the list of priorities. Due to scheduling, we're expecting to make more forward progress next summer.

[Mikaela]

Thanks for the update, I am happy to hear that knocking is on the list of priorities even if not that high on it

[rettichschnidi]

Tried the current state, and seems very well done to me. Thanks!

Regarding spaces: Are there any ideas/plans on making knocking work for them too? As of Element Web 1.11.46, I can enable knocking for spaces, and users can knock, but the admin of the space does not get a notification about the request, thus is not able to accept/deny them.

[Sun-Laura]

As mentioned some months ago we contributed to the knocking feature for the past few weeks. Our focus is still the implementation in the rooms.
As you @rettichschnidi mentioned, the knocking for spaces might be also a great value. Despite this it is not our focus yet, maybe Element itself has a more concrete plan for spaces or someone else can take over to contribute. ;)